kbendick commented on a change in pull request #4147:
URL: https://github.com/apache/iceberg/pull/4147#discussion_r809685446
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
##########
@@ -248,7 +247,7 @@ private void performRewrite(List<ManifestFile>
currentManifests) {
}
});
} finally {
-
Tasks.foreach(writers.values()).executeWith(ThreadPools.getWorkerPool()).run(WriterWrapper::close);
+
Tasks.foreach(writers.values()).executeWith(planExecutorService()).run(WriterWrapper::close);
}
Review comment:
Should we also close the executor service or is that not possible yet or
otherwise undesired? For example, the worker pool presently is persistent iirc
so we might not be able to control the lifecycle of this executor here.
cc @RussellSpitzer with whom I was discussing this recently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
