rdblue commented on a change in pull request #4147:
URL: https://github.com/apache/iceberg/pull/4147#discussion_r810657181



##########
File path: core/src/test/java/org/apache/iceberg/TestRewriteManifests.java
##########
@@ -81,6 +83,43 @@ public void testRewriteManifestsAppendedDirectly() throws 
IOException {
                             statuses(ManifestEntry.Status.EXISTING));
   }
 
+  @Test
+  public void testRewriteManifestsWithPlanExecutor() throws IOException {
+    Table table = load();
+
+    table.updateProperties().set(SNAPSHOT_ID_INHERITANCE_ENABLED, 
"true").commit();
+
+    ManifestFile newManifest = writeManifest(
+        "manifest-file-1.avro",
+        manifestEntry(ManifestEntry.Status.ADDED, null, FILE_A));
+
+    table.newFastAppend()
+        .appendManifest(newManifest)
+        .commit();
+    long appendId = table.currentSnapshot().snapshotId();
+
+    Assert.assertEquals(1, table.currentSnapshot().allManifests().size());
+    AtomicInteger planThreadsIndex = new AtomicInteger(0);
+    table.rewriteManifests()
+        .clusterBy(file -> "")

Review comment:
       I think this was copied from another test. The main thing is that this 
is a reasonable call to `rewriteManifests`. What it actually does isn't too 
important.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to