yittg commented on a change in pull request #4147:
URL: https://github.com/apache/iceberg/pull/4147#discussion_r809694039
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
##########
@@ -248,7 +247,7 @@ private void performRewrite(List<ManifestFile>
currentManifests) {
}
});
} finally {
-
Tasks.foreach(writers.values()).executeWith(ThreadPools.getWorkerPool()).run(WriterWrapper::close);
+
Tasks.foreach(writers.values()).executeWith(planExecutorService()).run(WriterWrapper::close);
}
Review comment:
I think we should not close it here. It should be managerd where it's is
provided:
1. if it's provided by calling `planWith`, then it ownership belongs to the
caller;
2. if it's the default persistent worker pool like before, then it can not
be closed.
##########
File path: core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java
##########
@@ -248,7 +247,7 @@ private void performRewrite(List<ManifestFile>
currentManifests) {
}
});
} finally {
-
Tasks.foreach(writers.values()).executeWith(ThreadPools.getWorkerPool()).run(WriterWrapper::close);
+
Tasks.foreach(writers.values()).executeWith(planExecutorService()).run(WriterWrapper::close);
}
Review comment:
I think we should not close it here. It should be managed where it's is
provided:
1. if it's provided by calling `planWith`, then it ownership belongs to the
caller;
2. if it's the default persistent worker pool like before, then it can not
be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
