rdblue commented on a change in pull request #4166:
URL: https://github.com/apache/iceberg/pull/4166#discussion_r810653025
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java
##########
@@ -194,8 +201,12 @@ void persistGlueTable(Table glueTable, Map<String, String>
parameters, TableMeta
.name(tableName)
.tableType(GLUE_EXTERNAL_TABLE_TYPE)
.parameters(parameters)
- .build())
- .build());
+ .build());
+ // Use Optimistic locking with version id while updating table
+ if (!LOAD_VERSION_ID.isNoop()) {
+ updateTableRequest.versionId(glueTable.versionId());
Review comment:
Why not use reflection to call the method as well? That seems slightly
safer, although I guess it is fine as long as you've tested this with older SDK
versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
