jackye1995 commented on a change in pull request #4166:
URL: https://github.com/apache/iceberg/pull/4166#discussion_r811369798
##########
File path: core/src/main/java/org/apache/iceberg/util/LockManagers.java
##########
@@ -54,6 +55,15 @@ public static LockManager from(Map<String, String>
properties) {
}
}
+ public static LockManager from(DynMethods.UnboundMethod setVersionId,
Map<String, String> properties) {
Review comment:
I think we don't need to do this in the core library, we can just apply
the logic in the GlueCatalog when initializing the catalog. This is too
specific implementation detail for the GlueCatalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
