rdblue commented on a change in pull request #4166:
URL: https://github.com/apache/iceberg/pull/4166#discussion_r810653150
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java
##########
@@ -63,6 +64,12 @@
private final FileIO fileIO;
private final LockManager lockManager;
+ // Attempt to load versionId if available on the path
+ private static final DynMethods.UnboundMethod LOAD_VERSION_ID =
DynMethods.builder("versionId")
+
.hiddenImpl("software.amazon.awssdk.services.glue.model.UpdateTableRequest$Builder",
String.class)
+ .orNoop()
+ .build();
Review comment:
It's a little unclear what this method is doing. It looks like this sets
a requirement that the table has not changed since the given version ID? If so,
then I think the comment below could be more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
