samredai commented on a change in pull request #4081:
URL: https://github.com/apache/iceberg/pull/4081#discussion_r810664594
##########
File path: python/src/iceberg/io/base.py
##########
@@ -76,7 +76,15 @@ def close(self) -> None:
class InputFile(ABC):
- """A base class for InputFile implementations"""
+ """A base class for InputFile implementations
+
+ Args:
+ location(str): A URI or a path to a local file
+
+ Attributes:
+ location(str): The URI or path to a local file for an InputFile
instance
+ exists(bool): Whether the file exists or not
+ """
Review comment:
We have `close` as part of the `InputStream` and `OutputStream`
protocol. I don't think we manage the file object's state in the `InputFile`
and `OutputFile` classes, do we still need a `close` there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
