aokolnychyi commented on a change in pull request #4152:
URL: https://github.com/apache/iceberg/pull/4152#discussion_r812492614
##########
File path:
spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestExpireSnapshotsProcedure.java
##########
@@ -283,4 +283,31 @@ public void testExpireDeleteFiles() throws Exception {
Assert.assertFalse("Delete manifest should be removed",
localFs.exists(deleteManifestPath));
Assert.assertFalse("Delete file should be removed",
localFs.exists(deleteFilePath));
}
+
+ @Test
+ public void testExpireSnapshotWithStreamResultsEnabled() {
+ sql("CREATE TABLE %s (id bigint NOT NULL, data string) USING iceberg",
tableName);
+
+ sql("INSERT INTO TABLE %s VALUES (1, 'a')", tableName);
+ sql("INSERT INTO TABLE %s VALUES (2, 'b')", tableName);
+
+ Table table = validationCatalog.loadTable(tableIdent);
+
+ Assert.assertEquals("Should be 2 snapshots", 2,
Iterables.size(table.snapshots()));
+
+ waitUntilAfter(table.currentSnapshot().timestampMillis());
+
+ Timestamp currentTimestamp =
Timestamp.from(Instant.ofEpochMilli(System.currentTimeMillis()));
+
+ List<Object[]> output = sql(
Review comment:
The formatting is off here too. Should be 4 spaces instead of 8 for
continued indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
