0xffmeta commented on a change in pull request #4152:
URL: https://github.com/apache/iceberg/pull/4152#discussion_r812580046
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseExpireSnapshotsSparkAction.java
##########
@@ -70,12 +70,13 @@
extends BaseSparkAction<ExpireSnapshots, ExpireSnapshots.Result>
implements ExpireSnapshots {
private static final Logger LOG =
LoggerFactory.getLogger(BaseExpireSnapshotsSparkAction.class);
+ // Make this variable public to be referenced for procedure option update
Review comment:
I think putting the constant into `ExpireSnapshots` might be a good
idea, and also I noticed that actions are all base class, e.g.
`BaseExpireSnapshotsSparkAction`. Does this mean that the behavior can be
overwritten in future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
