0xffmeta commented on a change in pull request #4152:
URL: https://github.com/apache/iceberg/pull/4152#discussion_r812591560
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestExpireSnapshotsAction.java
##########
@@ -1027,34 +1029,59 @@ public void testExpireAction() {
@Test
public void testUseLocalIterator() {
Review comment:
I think we can hardcode the job number for localIterator, but I'm
expecting this testcase to test out the different behavior for `stream-results`
option. If we hardcode the job number, we probably need to separate this into
two testcases:
1. use `toLocalIterator` with expected job number
2. use `collectAsList` with expected job numer
Does this make sense to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
