RussellSpitzer commented on a change in pull request #3411:
URL: https://github.com/apache/iceberg/pull/3411#discussion_r813260910
##########
File path: core/src/main/java/org/apache/iceberg/AllManifestsTable.java
##########
@@ -134,14 +136,14 @@ public long targetSplitSize() {
.withRecordCount(1)
.withFormat(FileFormat.AVRO)
.build();
- return new ManifestListReadTask(ops.io(), schema(), table().spec(),
new BaseFileScanTask(
+ return new ManifestListReadTask(ops.io(), schema(), specs, new
BaseFileScanTask(
manifestListAsDataFile, null,
schemaString, specString, residuals));
} else {
return StaticDataTask.of(
ops.io().newInputFile(ops.current().metadataFileLocation()),
MANIFEST_FILE_SCHEMA, schema(), snap.allManifests(),
- manifest -> ManifestsTable.manifestFileToRow(table().spec(),
manifest)
+ manifest ->
ManifestsTable.manifestFileToRow(specs.get(manifest.partitionSpecId()),
manifest)
Review comment:
Is this change needed, shouldn't we be using the common spec from table
built in Partitioning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
