RussellSpitzer commented on a change in pull request #3411:
URL: https://github.com/apache/iceberg/pull/3411#discussion_r813265025
##########
File path: core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java
##########
@@ -63,6 +67,28 @@ private void preparePartitionedTable() {
.commit();
}
+ @Test
+ public void testManifestsTableWithDroppedPartition() throws IOException {
Review comment:
I think the key part of this test is we should be checking a dropped V1
Field whose return type changes when dropped. As is this test I believe would
always pass on a V2 table even without this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
