RussellSpitzer commented on a change in pull request #3411:
URL: https://github.com/apache/iceberg/pull/3411#discussion_r813396462
##########
File path: core/src/test/java/org/apache/iceberg/TestPartitioning.java
##########
@@ -140,9 +140,10 @@ public void
testPartitionTypeWithAddingBackSamePartitionFieldInV1Table() {
.addField("data")
.commit();
- // in v1, we use void transforms instead of dropping partition fields
+ // in v1, we use void transforms instead of dropping partition fields.
+ // We restored the void transforms with the original dropped partition
fields.
Review comment:
I'm not sure line 144 here makes sense to me, I think this is fine
without the comment. In fact I think the expected type makes more sense now
than it previously did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
