openinx commented on a change in pull request #4132:
URL: https://github.com/apache/iceberg/pull/4132#discussion_r815693672
##########
File path: api/src/main/java/org/apache/iceberg/PartitionKey.java
##########
@@ -98,11 +98,12 @@ public String toPath() {
* @param row a StructLike row
*/
@SuppressWarnings("unchecked")
- public void partition(StructLike row) {
+ public PartitionKey partition(StructLike row) {
Review comment:
Yes, I'm currently checking the whole write path. I think I will need
one or two day to understand the whole newly introduced writers since 0.13.x.
Replacing the old writer API with the new one is a great thing. I think we can
collaborate to make this forward. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
