dungdm93 commented on a change in pull request #4132:
URL: https://github.com/apache/iceberg/pull/4132#discussion_r808919040
##########
File path: core/src/main/java/org/apache/iceberg/io/FileWriter.java
##########
@@ -51,8 +51,9 @@ default void write(Iterable<T> rows) {
* Writes a row to a predefined spec/partition.
*
* @param row a data or delete record
+ * @return PathOffset of written row
*/
- void write(T row);
+ PathOffset write(T row);
Review comment:
I agree that not every writer need `PathOffset`, but it's required for
writing delta data.
For the writer that does not need this, just ignore the return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
