openinx commented on a change in pull request #4132:
URL: https://github.com/apache/iceberg/pull/4132#discussion_r815631634
##########
File path: api/src/main/java/org/apache/iceberg/PartitionKey.java
##########
@@ -98,11 +98,12 @@ public String toPath() {
* @param row a StructLike row
*/
@SuppressWarnings("unchecked")
- public void partition(StructLike row) {
+ public PartitionKey partition(StructLike row) {
Review comment:
The downstream users may add this `iceberg-api` module to their
application project, since the `PartitionKey` is a public API, then their
application artifact does include the `void partition(StructLike row)` . When
they upgrade their `iceberg-api` to the next release version, then it will
fail to load the expected `void partition(StructLike row)`. That breaks a
user's normal upgrade process and that's why we say it's an API compatibility
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
