rajarshisarkar commented on a change in pull request #4248:
URL: https://github.com/apache/iceberg/pull/4248#discussion_r817654087
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java
##########
@@ -179,8 +196,12 @@ static void validateTableIdentifier(TableIdentifier
tableIdentifier) {
*/
static void setTableInputInformation(TableInput.Builder tableInputBuilder,
TableMetadata metadata) {
try {
+ StorageDescriptor.Builder storageDescriptor =
StorageDescriptor.builder();
+ if (!SET_ADDITIONAL_LOCATIONS.isNoop()) {
+ SET_ADDITIONAL_LOCATIONS.invoke(storageDescriptor,
getAdditionalLocations(metadata));
+ }
Review comment:
nit: newline after if block
##########
File path:
aws/src/test/java/org/apache/iceberg/aws/glue/TestIcebergToGlueConverter.java
##########
@@ -40,6 +42,11 @@
public class TestIcebergToGlueConverter {
+ private final Map<String, String> tableMetaDataProperties = ImmutableMap.of(
+ TableProperties.WRITE_DATA_LOCATION, "s3://writeDataLoc",
+ TableProperties.WRITE_METADATA_LOCATION, "s3://writeMetaDataLoc",
+ TableProperties.WRITE_FOLDER_STORAGE_LOCATION,
"s3://writeFolderStorageLoc");
Review comment:
Let's test a key will null values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
