jackye1995 commented on a change in pull request #4248:
URL: https://github.com/apache/iceberg/pull/4248#discussion_r818321205
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java
##########
@@ -276,4 +298,11 @@ private static void addColumnWithDedupe(List<Column>
columns, Set<String> dedupe
dedupe.add(field.name());
}
}
+
+ private static Set<String> getAdditionalLocations(TableMetadata
tableMetadata) {
Review comment:
I think this method is simple enough that we can just put it in the main
method, no need to have a separated helper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
