jackye1995 commented on a change in pull request #4248:
URL: https://github.com/apache/iceberg/pull/4248#discussion_r818322126
##########
File path:
aws/src/test/java/org/apache/iceberg/aws/glue/TestIcebergToGlueConverter.java
##########
@@ -216,6 +229,10 @@ public void
testSetTableInputInformationWithRemovedColumns() {
.build())
.build();
+ Assert.assertEquals(
+ "additionalLocations do not match",
Review comment:
the message here should describe the expected behavior, instead of the
wrong behavior, like `"additionalLocations should match"`. It seems like we are
also doing this wrong at L237 and L241, could you update those messages as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
