jackye1995 commented on a change in pull request #4254:
URL: https://github.com/apache/iceberg/pull/4254#discussion_r818091240
##########
File path:
core/src/main/java/org/apache/iceberg/hadoop/HadoopMetricsContext.java
##########
@@ -49,7 +49,7 @@ public HadoopMetricsContext(String scheme) {
public void initialize(Map<String, String> properties) {
// FileIO has no specific implementation class, but Hadoop will
// still track and report for the provided scheme.
- this.scheme = properties.getOrDefault(SCHEME, scheme);
+ this.scheme = properties.getOrDefault(CatalogProperties.IO_METRICS_SCHEME,
scheme);
Review comment:
I think we no longer need constructor `public
HadoopMetricsContext(String scheme)`, we should use a no-arg constructor
because we are already initializing the scheme here. The scheme should be
passed in from S3FileIO.
##########
File path:
core/src/main/java/org/apache/iceberg/hadoop/HadoopMetricsContext.java
##########
@@ -49,7 +49,7 @@ public HadoopMetricsContext(String scheme) {
public void initialize(Map<String, String> properties) {
// FileIO has no specific implementation class, but Hadoop will
// still track and report for the provided scheme.
- this.scheme = properties.getOrDefault(SCHEME, scheme);
+ this.scheme = properties.getOrDefault(CatalogProperties.IO_METRICS_SCHEME,
scheme);
Review comment:
I think we no longer need constructor `public
HadoopMetricsContext(String scheme)`, we should use a no-arg constructor
because we are already initializing the scheme here. The scheme should be
passed in from S3FileIO through the properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
