jackye1995 commented on a change in pull request #4254:
URL: https://github.com/apache/iceberg/pull/4254#discussion_r818088982
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
##########
@@ -117,14 +117,16 @@ public void initialize(Map<String, String> properties) {
}
// Report Hadoop metrics if Hadoop is available
+ String metricsImpl = properties.getOrDefault(
Review comment:
can we move this chunk of initialization logic to `CatalogUtil` next to
`loadFileIO`? Something like
```
CatalogUtil.loadFileIOMetricsContext(String impl,
Map<String, String> properties,
Object hadoopConf)
```
and scheme can be passed in as a part of the properties for initialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
