nastra commented on a change in pull request #4266:
URL: https://github.com/apache/iceberg/pull/4266#discussion_r819572972



##########
File path: 
core/src/test/java/org/apache/iceberg/rest/requests/TestCreateNamespaceRequest.java
##########
@@ -166,6 +139,6 @@ public void assertEquals(CreateNamespaceRequest actual, 
CreateNamespaceRequest e
 
   @Override
   public CreateNamespaceRequest deserialize(String json) throws 
JsonProcessingException {
-    return mapper().readValue(json, CreateNamespaceRequest.class).validate();

Review comment:
       note that we don't have to explicitly validate anymore as objects 
created via Immutables are by definition always in a valid state.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to