nastra commented on a change in pull request #4266:
URL: https://github.com/apache/iceberg/pull/4266#discussion_r819573729
##########
File path:
core/src/test/java/org/apache/iceberg/rest/requests/TestUpdateNamespacePropertiesRequest.java
##########
@@ -45,35 +45,38 @@ public void testRoundTripSerDe() throws
JsonProcessingException {
// Full request
String fullJson =
"{\"removals\":[\"foo\",\"bar\"],\"updates\":{\"owner\":\"Hank\"}}";
assertRoundTripSerializesEquallyFrom(
- fullJson,
UpdateNamespacePropertiesRequest.builder().updateAll(UPDATES).removeAll(REMOVALS).build());
+ fullJson,
ImmutableUpdateNamespacePropertiesRequest.builder().updates(UPDATES).removals(REMOVALS).build());
Review comment:
given that we're directly working with the `updates` / `removals`
collection, it's actually easier to use directly the builder from
`ImmutableUpdateNamespacePropertiesRequest` and not have simplified `of(..)`
methods like in the other class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
