nastra commented on a change in pull request #4266:
URL: https://github.com/apache/iceberg/pull/4266#discussion_r819575004
##########
File path:
core/src/test/java/org/apache/iceberg/rest/requests/TestCreateNamespaceRequest.java
##########
@@ -73,76 +69,56 @@ public void testCanDeserializeWithoutDefaultValues() throws
JsonProcessingExcept
@Test
public void testDeserializeInvalidRequest() {
String jsonIncorrectTypeForNamespace =
"{\"namespace\":\"accounting%00tax\",\"properties\":null}";
- AssertHelpers.assertThrows(
Review comment:
the reason I changed this to `Assertions.assertThatThrownBy` is because
that I think the message in `AssertHelpers.assertThrows(..)` is rather noisy.
Usually it's clear from looking at the code what's being expected and when the
assertion itself fails, it will be descriptive enough to understand why the
code fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
