samredai commented on a change in pull request #4262:
URL: https://github.com/apache/iceberg/pull/4262#discussion_r820017298
##########
File path: python/.coveragerc
##########
@@ -20,5 +20,5 @@ skip_empty = true
[run]
omit =
- # omit this single file
- src/iceberg/literals.py
+ src/iceberg/expression/literals.py
Review comment:
nit: should we make the directory name plural, as in `expressions`? I'm
thinking of how there are different types of expressions that will be defined
here like And, Or, Not etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
