dramaticlly commented on a change in pull request #4262:
URL: https://github.com/apache/iceberg/pull/4262#discussion_r820018089
##########
File path: python/.coveragerc
##########
@@ -20,5 +20,5 @@ skip_empty = true
[run]
omit =
- # omit this single file
- src/iceberg/literals.py
+ src/iceberg/expression/literals.py
Review comment:
ops, yes you are right @samredai , the only problem with that is that
[expressions.py](https://github.com/apache/iceberg/blob/master/python/src/iceberg/expressions.py#L21)
already exists under the name `iceberg.expressions` so it will conflict when I
try to import is as module. As you suggested, I plan to rename the file in a
separate PR to get the directory naming correctly as what you suggested, what
do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
