rdblue edited a comment on pull request #4254:
URL: https://github.com/apache/iceberg/pull/4254#issuecomment-1062031477
What I was thinking is a mix-in interface for `FileIO` that allows the
engine to set the metrics context. We could default to Hadoop since that's what
happens with `HadoopFileIO` automatically, but if you want to get passed
metrics directly then you can set the context:
```java
FileIO io = table.io();
if (io instanceof MetricsProducer) {
((MetricsProducer) io).setMetricsContext(engineContext);
}
```
What do you think, @jackye1995?
For reporting metrics to CloudWatch, wouldn't you integrate with the engine
rather than with low-level libraries? You certainly could integrate directly if
you wanted to. But I thought you'd probably want full metrics from the engine,
not just what you can get from Iceberg file interaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
