rdblue commented on pull request #4254: URL: https://github.com/apache/iceberg/pull/4254#issuecomment-1062169188
> Correct, however the current HadoopMetricsContext seems to be doing this across all the engines, and this offers a unique benefit for HadoopFileIO users that they are able to see their FileIO metrics across all compute platforms aggregate through the Hadoop FileSystem interface. This is just a convenient way to get metrics to engines that already use Hadoop. I think we all agree that we want to be able to extend this, but it is a reasonable default for now. > think it still makes sense to have some sort of default behavior controlled through catalog level property, maybe in the name of io.metrics.default.type which is limited to a few specific types including hadoop and collectd, and io.metrics.default.namespace provides the namespace of the metrics. I don't think we are at a point where there's a good argument for catalog-level configuration. Catalog configuration would be in conflict with what engines need and we would have to find a more complicated way to avoid this problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
