samredai commented on a change in pull request #4285:
URL: https://github.com/apache/iceberg/pull/4285#discussion_r822235103
##########
File path: python/setup.py
##########
@@ -19,7 +19,14 @@
setup(
name="py-iceberg",
- install_requires=[],
+ install_requires=[
Review comment:
These should go in setup.cfg under `[options]`. Did you get these from
the dependencies from the legacy python client's setup.py? I think we should
incrementally add dependencies as PR's require them. We also need to determine
which are optional dependencies and how to group them. For now I think pyarrow
is the only missing dependency:
*setup.cfg*
```
[options]
...
install_requires =
pyarrow
```
As later PRs introduce optional dependencies, we can add them like so
(setuptools
[docs](https://setuptools.pypa.io/en/latest/userguide/declarative_config.html?highlight=options.extras_require#configuring-setup-using-setup-cfg-files)):
```
[options.extras_require]
boto3 =
boto3
hive =
hmsclient==0.1.1
smart-open =
smart-open
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
