samredai commented on a change in pull request #4285:
URL: https://github.com/apache/iceberg/pull/4285#discussion_r823936298



##########
File path: python/setup.cfg
##########
@@ -42,6 +42,16 @@ package_dir =
     = src
 packages = find:
 python_requires = >=3.7
+install_requires =
+    pytz
+    retrying
+    mmh3
+    fastavro>=1.3.2<1.4.0
+    hmsclient==0.1.1
+    boto3
+    pyarrow
+[options.extras_require]
+dev = tox-travis==0.12; pytest

Review comment:
       Can this be formatted just like the `install_requires`?
   ```
   [options.extras_require]
   dev =
       tox-travis==0.12
       pytest
   ```

##########
File path: python/setup.cfg
##########
@@ -42,6 +42,16 @@ package_dir =
     = src
 packages = find:
 python_requires = >=3.7
+install_requires =
+    pytz
+    retrying
+    mmh3
+    fastavro>=1.3.2<1.4.0
+    hmsclient==0.1.1
+    boto3
+    pyarrow

Review comment:
       A few of these will be added 
[here](https://github.com/apache/iceberg/pull/4262/files#diff-1f5419f88832f5bdcc37bc3ef9cfd11a714489c537227ec469756177a2b1578eR45)
 as part of PR #4262 and some will be part of upcoming PR's (like boto3 being 
added as part of a `BotoFileIO` PR and hmsclient being added as part of a 
`HiveCatalog` PR). I think this list can be reduced to just `pyarrow` for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to