Fokko commented on a change in pull request #4285:
URL: https://github.com/apache/iceberg/pull/4285#discussion_r828821940
##########
File path: python/setup.cfg
##########
@@ -42,6 +42,16 @@ package_dir =
= src
packages = find:
python_requires = >=3.7
+install_requires =
+ pytz
+ retrying
+ mmh3
+ fastavro>=1.3.2<1.4.0
+ hmsclient==0.1.1
+ boto3
+ pyarrow
Review comment:
Hey @samredai @rdblue Great point, and I agree. Pulling in boto might be
too much if you don't use it at all, same for Hive.
Ps. Maybe later on we also might want to look into a full dependency
management system for the python codebase. Something like
[Poetry](https://python-poetry.org/) or [PDM](https://pdm.fming.dev/). We don't
really pin versions of packages, which might cause problems when a downstream
package is released with a breaking change (which unfortunately [still
happens](https://github.com/dbt-labs/dbt-core/issues/4745) quite a lot).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
