kbendick commented on a change in pull request #4245:
URL: https://github.com/apache/iceberg/pull/4245#discussion_r825086498
##########
File path: build.gradle
##########
@@ -212,6 +212,7 @@ project(':iceberg-core') {
exclude group: 'org.tukaani' // xz compression is not supported
}
+ implementation 'org.apache.httpcomponents.client5:httpclient5'
Review comment:
Yes I do tend to agree that the OkHTTP library is more feature rich and
intuitive. There's also a large amount of code we can repurpose from Trino etc
with it.
I think since this is already written, to unblock integrating the actual
catalog in, it might be good to add this implentation so that other tasks can
be worked on, and then possibly refactor this class after that if we decide to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
