kbendick commented on a change in pull request #4245: URL: https://github.com/apache/iceberg/pull/4245#discussion_r835529987
########## File path: core/src/main/java/org/apache/iceberg/rest/HTTPClient.java ########## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.ObjectMapper; +import java.io.IOException; +import java.net.URI; +import java.util.Map; +import java.util.function.Consumer; +import org.apache.hc.client5.http.classic.methods.HttpUriRequest; +import org.apache.hc.client5.http.classic.methods.HttpUriRequestBase; +import org.apache.hc.client5.http.impl.classic.CloseableHttpClient; +import org.apache.hc.client5.http.impl.classic.CloseableHttpResponse; +import org.apache.hc.client5.http.impl.classic.HttpClients; +import org.apache.hc.core5.http.ContentType; +import org.apache.hc.core5.http.HttpHeaders; +import org.apache.hc.core5.http.HttpStatus; +import org.apache.hc.core5.http.Method; +import org.apache.hc.core5.http.ParseException; +import org.apache.hc.core5.http.impl.EnglishReasonPhraseCatalog; +import org.apache.hc.core5.http.io.entity.EntityUtils; +import org.apache.hc.core5.http.io.entity.StringEntity; +import org.apache.hc.core5.io.CloseMode; +import org.apache.iceberg.exceptions.RESTException; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.rest.responses.ErrorResponse; +import org.apache.iceberg.rest.responses.ErrorResponseParser; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * An HttpClient for usage with the REST catalog. + */ +public class HTTPClient implements RESTClient { + + private static final Logger LOG = LoggerFactory.getLogger(HTTPClient.class); + + private final String uri; + private final CloseableHttpClient httpClient; + private final ObjectMapper mapper; + private final Map<String, String> additionalHeaders; + + private HTTPClient( + String uri, CloseableHttpClient httpClient, ObjectMapper mapper, Map<String, String> additionalHeaders) { + this.uri = uri; + this.httpClient = httpClient != null ? httpClient : HttpClients.createDefault(); + this.mapper = mapper != null ? mapper : new ObjectMapper(); + this.additionalHeaders = additionalHeaders != null ? additionalHeaders : ImmutableMap.of(); + } + + private static String extractResponseBodyAsString(CloseableHttpResponse response) { + try { + if (response.getEntity() == null) { + return null; + } + + // EntityUtils.toString returns null when HttpEntity.getContent returns null. + return EntityUtils.toString(response.getEntity(), "UTF-8"); + } catch (IOException | ParseException e) { + throw new RESTException(e, "Failed to convert HTTP response body to string"); + } + } + + // Per the spec, the only currently defined / used "success" responses are 200 and 202. + private static boolean isSuccessful(CloseableHttpResponse response) { + int code = response.getCode(); + return code == HttpStatus.SC_OK || code == HttpStatus.SC_ACCEPTED; + } + + private static ErrorResponse buildDefaultErrorResponse(CloseableHttpResponse response) { + String responseReason = response.getReasonPhrase(); + String message = + responseReason != null && !responseReason.isEmpty() ? responseReason : + EnglishReasonPhraseCatalog.INSTANCE.getReason(response.getCode(), null /* ignored */); + String type = "RESTException"; + return ErrorResponse.builder() + .responseCode(response.getCode()) + .withMessage(message) + .withType(type) + .build(); + } + + private static void handleFailure( + CloseableHttpResponse response, String responseBody, Consumer<ErrorResponse> errorHandler) { + ErrorResponse errorResponse = null; + + if (responseBody != null) { + try { + errorResponse = ErrorResponseParser.fromJson(responseBody); + } catch (Exception e) { Review comment: This throws `JsonProcessingException` and `JsonMappingException` in the call to reading the `resposneBody` as `JsonNode`, but it catches those (as they're subclasses of `IOException`) and rethrows them as `UncheckedIOExcepion`. Looking more closely, it can also throw `IllegalArgumentException` due to some precondition checks. So I think if we catch `UncheckedIOException` and `IllegalArgumentException`, that should cover everything as it currently is. I'm also thinking of updating `ErrorResponseParser` to catch those `IllegalArgumentException` and rethrow them as `UncheckedIOException` to simplify the possible exceptions it can throw. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
