amogh-jahagirdar commented on a change in pull request #4259:
URL: https://github.com/apache/iceberg/pull/4259#discussion_r821029815
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java
##########
@@ -81,14 +84,36 @@ public S3FileIO(SerializableSupplier<S3Client> s3,
AwsProperties awsProperties)
this.awsProperties = awsProperties;
}
+ /**
+ * Constructor with custom s3 supplier and s3 tags
+ * <p>
+ * Calling {@link S3FileIO#initialize(Map)} will overwrite information set
in this constructor.
+ * param s3 s3 supplier
+ * @param tags s3 tags
+ */
+ public S3FileIO(SerializableSupplier<S3Client> s3, List<Tag> tags) {
+ this(s3, new AwsProperties());
+ this.tags = tags;
+ }
+
+ /**
+ * Constructor with custom s3 tags
+ * <p>
+ * Calling {@link S3FileIO#initialize(Map)} will overwrite information set
in this constructor.
+ * @param tags s3 tags
+ */
+ public S3FileIO(List<Tag> tags) {
+ this.tags = tags;
+ }
+
Review comment:
Instead of this would it make sense to have 1 constructor with 3 args:
s3, awsProperties, and tags? In the existing constructors we would pass an
empty list for the tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
