jackye1995 commented on a change in pull request #4259:
URL: https://github.com/apache/iceberg/pull/4259#discussion_r825079374
##########
File path: aws/src/test/java/org/apache/iceberg/aws/s3/TestS3OutputStream.java
##########
@@ -116,7 +122,8 @@ public void testWrite() {
public void testAbortAfterFailedPartUpload() {
doThrow(new
RuntimeException()).when(s3mock).uploadPart((UploadPartRequest) any(),
(RequestBody) any());
- try (S3OutputStream stream = new S3OutputStream(s3mock, randomURI(),
properties, nullMetrics())) {
+ try (S3OutputStream stream = new S3OutputStream(s3mock, randomURI(),
properties, nullMetrics(),
Review comment:
nit: prefer method arguments all on next lines of it has to span
multiple lines, e.g.
```
try (S3OutputStream stream = new S3OutputStream(
s3mock, randomURI(), properties, nullMetrics(), tags)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
