jackye1995 commented on a change in pull request #4259:
URL: https://github.com/apache/iceberg/pull/4259#discussion_r825025513
##########
File path: core/src/main/java/org/apache/iceberg/util/PropertyUtil.java
##########
@@ -70,4 +73,26 @@ public static String propertyAsString(Map<String, String>
properties,
}
return defaultValue;
}
+
+ /**
+ * Returns subset of provided map with keys matching the provided prefix.
Matching is case-sensitive and the matching
+ * prefix is removed from the keys in returned map.
+ *
+ * @param properties input map
+ * @param prefix prefix to choose keys from input map
+ * @return subset of input map with keys starting with provided prefix and
prefix trimmed out
+ */
+ public static Map<String, String> propertiesWithPrefix(Map<String, String>
properties,
Review comment:
prefer method arguments all on next lines of it has to span multiple
lines, e.g.
```java
propertiesWithPrefix(
Map<String, String> properties,
String prefix) {
```
##########
File path: core/src/main/java/org/apache/iceberg/util/PropertyUtil.java
##########
@@ -70,4 +73,26 @@ public static String propertyAsString(Map<String, String>
properties,
}
return defaultValue;
}
+
+ /**
+ * Returns subset of provided map with keys matching the provided prefix.
Matching is case-sensitive and the matching
+ * prefix is removed from the keys in returned map.
+ *
+ * @param properties input map
+ * @param prefix prefix to choose keys from input map
+ * @return subset of input map with keys starting with provided prefix and
prefix trimmed out
+ */
+ public static Map<String, String> propertiesWithPrefix(Map<String, String>
properties,
Review comment:
nit: prefer method arguments all on next lines of it has to span
multiple lines, e.g.
```java
propertiesWithPrefix(
Map<String, String> properties,
String prefix) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
