jackye1995 commented on a change in pull request #4334:
URL: https://github.com/apache/iceberg/pull/4334#discussion_r827258124
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputFile.java
##########
@@ -43,6 +44,11 @@ public static S3OutputFile fromLocation(String location,
S3Client client, AwsPro
return new S3OutputFile(client, new S3URI(location), awsProperties,
metrics, writeTags);
}
+ public static S3OutputFile fromLocation(String location, S3Client client,
AwsProperties awsProperties,
Review comment:
the `fromLocation` at L42 was just added, not released yet, we can just
update that method to also include this new field instead of creating a new
static helper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
