jackye1995 commented on a change in pull request #4334:
URL: https://github.com/apache/iceberg/pull/4334#discussion_r828404553
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java
##########
@@ -50,7 +52,21 @@
* @param location fully qualified URI
*/
S3URI(String location) {
+ this(location, ImmutableMap.of());
+ }
+
+ /**
+ * Creates a new S3URI in the form of scheme://bucket/key?query#fragment
Review comment:
the javadoc here does not really explain the additional mapping
information. I think the javadoc can be removed if they are duplicated, or we
explain it as "Create a new S3URI with additional information of bucket to
access point mapping"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
