anuragmantri commented on a change in pull request #4334:
URL: https://github.com/apache/iceberg/pull/4334#discussion_r827345481
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java
##########
@@ -50,6 +52,19 @@
* @param location fully qualified URI
*/
S3URI(String location) {
+ this(location, ImmutableMap.of());
+ }
+
+ /**
+ * Creates a new S3URI in the form of scheme://bucket/key?query#fragment
+ * <p>
+ * The URI supports any valid URI schemes to be backwards compatible with
s3a and s3n,
+ * and also allows users to use S3FileIO with other S3-compatible object
storage services like GCS.
+ *
+ * @param location fully qualified URI
+ * @param bucketToAccessPointMapping contains mapping of bucket to access
point
+ */
+ S3URI(String location, Map<String, String> bucketToAccessPointMapping) {
Preconditions.checkNotNull(location, "Location cannot be null.");
Review comment:
Nit: I'm not sure if `propertiesWithPrefix()` already ensures this but
could you add a null check for the `bucketToAccessPointMapping` as well here.
This cannot be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
