rajarshisarkar opened a new pull request #4350:
URL: https://github.com/apache/iceberg/pull/4350
This change moves S3 `writeTags` to `AwsProperties`. This provides a cleaner
solution as `AwsProperties` was designed to be the extension point for new
configs without changing constructors.
Users can pass their custom tags as part of the catalog properties.
Spark SQL launch command:
```
sh spark-sql --conf
spark.sql.catalog.my_catalog=org.apache.iceberg.spark.SparkCatalog \
--conf
spark.sql.catalog.my_catalog.warehouse=s3://iceberg-warehouse/s3-tagging \
--conf
spark.sql.catalog.my_catalog.catalog-impl=org.apache.iceberg.aws.glue.GlueCatalog
\
--conf
spark.sql.catalog.my_catalog.io-impl=org.apache.iceberg.aws.s3.S3FileIO \
--conf spark.sql.catalog.my_catalog.s3.write.tags.my_key=my_val \
--conf spark.sql.catalog.my_catalog.s3.write.tags.my_key2=my_val2
```
Tags added in S3:
```
aws s3api get-object-tagging --bucket iceberg-warehouse --key
s3-tagging/data/00000-0-7eb83d01-ad82-41ca-814b-c7686d9d9211-00001.parquet
{
"TagSet": [
{
"Key": "my_key2",
"Value": "my_val2"
},
{
"Key": "my_key",
"Value": "my_val"
}
]
}
```
---
cc: @jackye1995 @arminnajafi @singhpk234 @amogh-jahagirdar @xiaoxuandev
@yyanyy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
