singhpk234 commented on a change in pull request #4350:
URL: https://github.com/apache/iceberg/pull/4350#discussion_r828814860
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -339,6 +344,8 @@ public AwsProperties(Map<String, String> properties) {
this.dynamoDbTableName = PropertyUtil.propertyAsString(properties,
DYNAMODB_TABLE_NAME,
DYNAMODB_TABLE_NAME_DEFAULT);
+
+ this.s3WriteTags = toTags(properties, S3_WRITE_TAGS_PREFIX);
Review comment:
Ahh I see you made a check of tags != null below then it might not be
required, but I think still empty set as default is good as it avoids us
checking the null checks when it's being used. WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
