rajarshisarkar commented on a change in pull request #4350:
URL: https://github.com/apache/iceberg/pull/4350#discussion_r828895200
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -444,4 +451,15 @@ public boolean isS3ChecksumEnabled() {
public void setS3ChecksumEnabled(boolean eTagCheckEnabled) {
this.isS3ChecksumEnabled = eTagCheckEnabled;
}
+
+ public Set<Tag> getS3WriteTags() {
+ return s3WriteTags;
+ }
+
+ public Set<Tag> toTags(Map<String, String> properties, String prefix) {
+ return PropertyUtil.propertiesWithPrefix(properties, prefix)
+ .entrySet().stream()
+ .map(e -> Tag.builder().key(e.getKey()).value(e.getValue()).build())
+ .collect(Collectors.toSet());
+ }
Review comment:
It can be private here (unlike other methods of `AwsProperties` which
are public). I don't see a scope of `toTags` method to be used by other
classes. We can make it public later on, if required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
