jackye1995 commented on a change in pull request #4334:
URL: https://github.com/apache/iceberg/pull/4334#discussion_r829657187
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3URI.java
##########
@@ -50,7 +52,24 @@
* @param location fully qualified URI
*/
S3URI(String location) {
+ this(location, ImmutableMap.of());
+ }
+
+ /**
+ * Creates a new S3URI in the form of
scheme://(bucket|accessPoint)/key?query#fragment with additional information
+ * on accessPoints.
+ * <p>
+ * The URI supports any valid URI schemes to be backwards compatible with
s3a and s3n,
+ * and also allows users to use S3FileIO with other S3-compatible object
storage services like GCS.
+ * If the accessPoints contains a mapping of the given bucket used in
location then the corresponding accessPoint
Review comment:
nit: this sentence is a bit convoluted, what about "if the bucket in the
location has an access point in the mapping, the access point is used to
perform all the S3 operations"
##########
File path:
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java
##########
@@ -268,4 +306,11 @@ private void validateRead(S3FileIO s3FileIO) throws
Exception {
stream.close();
Assert.assertEquals(content, result);
}
+
+ private String testAccessPointARN() {
Review comment:
I think we also need to test cross-region endpoint, because I see this
S3 client config:
```
/**
* Returns whether the client is allowed to make cross-region calls when
an S3 Access Point ARN has a different
* region to the one configured on the client.
* <p>
* @return True if a different region in the ARN can be used.
*/
public boolean useArnRegionEnabled() {
return useArnRegionEnabled.value();
}
```
Maybe we should turn this on when access point is configured. Could you
check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
