rdblue commented on a change in pull request #4316:
URL: https://github.com/apache/iceberg/pull/4316#discussion_r830199603
##########
File path:
flink/v1.12/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java
##########
@@ -74,7 +82,8 @@ public void write(RowData row) throws IOException {
case INSERT:
case UPDATE_AFTER:
if (upsert) {
- writer.delete(row);
+ RowData wrap = RowDataProjection.create(schema,
deleteSchema).wrap(row);
Review comment:
This shouldn't create a new projection every time. Instead it should
create one and reuse it by calling `wrap` every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
