rdblue commented on a change in pull request #4316:
URL: https://github.com/apache/iceberg/pull/4316#discussion_r830201832
##########
File path:
flink/v1.12/flink/src/main/java/org/apache/iceberg/flink/sink/RowDataTaskWriterFactory.java
##########
@@ -70,9 +72,8 @@ public RowDataTaskWriterFactory(Table table,
if (equalityFieldIds == null || equalityFieldIds.isEmpty()) {
this.appenderFactory = new FlinkAppenderFactory(schema, flinkSchema,
table.properties(), spec);
} else {
- // TODO provide the ability to customize the equality-delete row schema.
this.appenderFactory = new FlinkAppenderFactory(schema, flinkSchema,
table.properties(), spec,
- ArrayUtil.toIntArray(equalityFieldIds), schema, null);
+ ArrayUtil.toIntArray(equalityFieldIds), TypeUtil.select(schema,
Sets.newHashSet(equalityFieldIds)), null);
Review comment:
This is the correct schema for `upsert` but should not be used for
`delete` when the row passed to the delete file is the deleted row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
