rdblue commented on a change in pull request #4316:
URL: https://github.com/apache/iceberg/pull/4316#discussion_r830201084
##########
File path:
flink/v1.12/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java
##########
@@ -57,6 +60,7 @@
this.schema = schema;
this.deleteSchema = TypeUtil.select(schema,
Sets.newHashSet(equalityFieldIds));
this.wrapper = new RowDataWrapper(flinkSchema, schema.asStruct());
+ this.wrapperDelete = new
RowDataWrapper(FlinkSchemaUtil.convert(deleteSchema), deleteSchema.asStruct());
Review comment:
How about `keyWrapper` instead?
##########
File path:
flink/v1.12/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java
##########
@@ -66,6 +70,10 @@ RowDataWrapper wrapper() {
return wrapper;
}
+ RowDataWrapper wrapperDelete() {
Review comment:
Why is there an accessor for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
