kbendick commented on a change in pull request #4316:
URL: https://github.com/apache/iceberg/pull/4316#discussion_r830386444
##########
File path:
flink/v1.13/flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java
##########
@@ -66,6 +70,10 @@ RowDataWrapper wrapper() {
return wrapper;
}
+ RowDataWrapper wrapperDelete() {
+ return wrapperDelete;
+ }
Review comment:
In this case, I believe that @hililiwei made the changes as existing
tests might not pass in earlier versions of Flink.
But for something important, we should still keep the changes in one PR
while reviewing. Otherwise it's difficult for others to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
