rdblue commented on a change in pull request #4376:
URL: https://github.com/apache/iceberg/pull/4376#discussion_r832549419
##########
File path: core/src/main/java/org/apache/iceberg/BaseFileScanTask.java
##########
@@ -220,12 +220,13 @@ public Expression residual() {
}
public boolean isAdjacent(SplitScanTask other) {
- return (other != null) &&
- (this.file().equals(other.file())) &&
- (this.offset + this.len == other.offset);
+ return other != null &&
+ this.file().equals(other.file()) &&
+ this.offset + this.len == other.offset;
}
}
+ @SuppressWarnings("MixedMutabilityReturnType")
Review comment:
This seems unrelated to the parentheses change. What is the purpose of
this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
