RussellSpitzer commented on a change in pull request #4376:
URL: https://github.com/apache/iceberg/pull/4376#discussion_r833366740
##########
File path: api/src/main/java/org/apache/iceberg/SnapshotRef.java
##########
@@ -86,7 +86,7 @@ public boolean equals(Object other) {
}
SnapshotRef ref = (SnapshotRef) other;
- return Objects.equals(ref.snapshotId(), snapshotId) &&
+ return ref.snapshotId() == snapshotId &&
Review comment:
I think it's fine if we disable the static analysis rule for this, just
because I like it when all the comparisons look the same but if we want to
follow this rule that's also ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
