RussellSpitzer commented on a change in pull request #4376:
URL: https://github.com/apache/iceberg/pull/4376#discussion_r833372101
##########
File path: api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java
##########
@@ -172,7 +172,7 @@ public boolean equals(Object o) {
@Override
public int hashCode() {
- return Objects.hash(wrapperSet);
+ return Objects.hashCode(wrapperSet);
Review comment:
I'm not very comfortable changing this because it's a public api. While
I don't think we actually serialize this anywhere, if someone did this would
probably cause an issue. That said if as a community we feel confident this
isn't going to be breaking we can change it.
Objects.hash will hash the hash of wrapperSet
Objects.hashCode will hash wrapperSet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
